openshift / cluster-olm-operator

OpenShift operator that manages the Operator Lifecycle Manager components
Apache License 2.0
0 stars 20 forks source link

Use build-machinery-go to build #17

Closed ncdc closed 1 year ago

ncdc commented 1 year ago

Use build-machinery-go to build so we get the version information from ART or git appropriately linked in.

Runs something like this:

/usr/local/opt/go/libexec/bin/go build -mod=vendor -trimpath -ldflags "-X github.com/openshift/cluster-olm-operator/pkg/version.versionFromGit="v0.0.0-unknown-a066ee2" -X github.com/openshift/cluster-olm-operator/pkg/version.commitFromGit="a066ee2" -X github.com/openshift/cluster-olm-operator/pkg/version.gitTreeState="clean" -X github.com/openshift/cluster-olm-operator/pkg/version.buildDate="2023-06-29T20:57:11Z" " -o 'bin/cluster-olm-operator' github.com/openshift/cluster-olm-operator/cmd/cluster-olm-operator

Fixes #12

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncdc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-olm-operator/blob/main/OWNERS)~~ [ncdc] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ncdc commented 1 year ago

/hold

Still looking at 1 thing

joelanford commented 1 year ago

/lgtm

openshift-ci[bot] commented 1 year ago

@ncdc: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
ncdc commented 1 year ago

/unhold