search

openshift / cluster-olm-operator

OpenShift operator that manages the Operator Lifecycle Manager components
Apache License 2.0
0 stars 20 forks source link

Improve deployment controller name generation #27

Closed joelanford closed 7 months ago

joelanford commented 1 year ago

In #25, I had to keep the namespace of the object out of the controller name to make the controller name generated for the operator controller deployment fit within the character count for finalizer name length

Without namespace, there's a possibility of a component putting a deployment with the same name in two namespaces, which would conflict.

I was hoping to make this somewhat human-friendly, but that seems iffy. A few other options are:

I'm also wondering what happens if these names change over time what if a previous version of cluster-olm-operator adds some conditions based on these names, then we change the names? I'm not sure anything knows to clean up the old names. This isn't really a new problem, but generating a name seems like it changes things from theoretical problem to likely problem.

Thoughts?

_Originally posted by @joelanford in https://github.com/openshift/cluster-olm-operator/pull/25#discussion_r1262889068_

openshift-bot commented 9 months ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot commented 8 months ago

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot commented 7 months ago

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci[bot] commented 7 months ago

@openshift-bot: Closing this issue.

In response to [this](https://github.com/openshift/cluster-olm-operator/issues/27#issuecomment-1863634497): >Rotten issues close after 30d of inactivity. > >Reopen the issue by commenting `/reopen`. >Mark the issue as fresh by commenting `/remove-lifecycle rotten`. >Exclude this issue from closing again by commenting `/lifecycle frozen`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.