search

openshift / cluster-olm-operator

OpenShift operator that manages the Operator Lifecycle Manager components
Apache License 2.0
0 stars 20 forks source link

OCPBUGS-29553: Apply hypershift cluster-profile for ibm-cloud-managed #46

Closed openshift-art-build-bot closed 3 months ago

openshift-art-build-bot commented 5 months ago

Since HyperShift / Hosted Control Plane have adopted include.release.openshift.io/ibm-cloud-managed, to tailor the resources of clusters running in the ROKS IBM environment, the include.release.openshift.io/hypershift addition will allow Hypershift to express different profile choices than ROKS

openshift-ci-robot commented 5 months ago

@openshift-art-build-bot: This pull request references Jira Issue OCPBUGS-29553, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @jianzhangbjz

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-olm-operator/pull/46): >Since HyperShift / Hosted Control Plane have adopted `include.release.openshift.io/ibm-cloud-managed`, to tailor the resources of clusters running in the ROKS IBM environment, the `include.release.openshift.io/hypershift` addition will allow Hypershift to express different profile choices than ROKS Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-olm-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
ashwindasr commented 5 months ago

If other files need to be updated to support this change, please let me know.

jianzhangbjz commented 5 months ago

test pass, details: https://issues.redhat.com/browse/OCPBUGS-29553 /lgtm /label qe-approved

ashwindasr commented 5 months ago

/retest

openshift-ci[bot] commented 5 months ago

@openshift-art-build-bot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
ashwindasr commented 5 months ago

@jianzhangbjz do you know who I need to reach out to get the approve label?

kevinrizza commented 3 months ago

/approve

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kevinrizza, openshift-art-build-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-olm-operator/blob/main/OWNERS)~~ [kevinrizza] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 3 months ago

@openshift-art-build-bot: Jira Issue OCPBUGS-29553: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-29553 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-olm-operator/pull/46): >Since HyperShift / Hosted Control Plane have adopted `include.release.openshift.io/ibm-cloud-managed`, to tailor the resources of clusters running in the ROKS IBM environment, the `include.release.openshift.io/hypershift` addition will allow Hypershift to express different profile choices than ROKS Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-olm-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 3 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-olm-operator-container-v4.16.0-202404051443.p0.g8845c0d.assembly.stream.el8 for distgit ose-cluster-olm-operator. All builds following this will include this PR.

openshift-merge-robot commented 3 months ago

Fix included in accepted release 4.16.0-0.nightly-2024-04-06-020637