search

openshift / cluster-olm-operator

OpenShift operator that manages the Operator Lifecycle Manager components
Apache License 2.0
0 stars 20 forks source link

OPRUN-3291: Add roles for clusterextensions #53

Closed m1kola closed 3 months ago

m1kola commented 3 months ago

These are required for validatingadmissionpolicies and validatingadmissionpolicybindings to work.

openshift-ci-robot commented 3 months ago

@m1kola: This pull request references OPRUN-3291 which is a valid jira issue.

In response to [this](https://github.com/openshift/cluster-olm-operator/pull/53): >These are required for validatingadmissionpolicies and validatingadmissionpolicybindings to work. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-olm-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
m1kola commented 3 months ago

/test lint

joelanford commented 3 months ago

/lgtm /approve

/hold Just want to see the e2e pass. I'm trying to remember if there's a reason that test isn't required. I can't think of a good reason we shouldn't make it required.

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelanford, m1kola

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-olm-operator/blob/main/OWNERS)~~ [joelanford] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 3 months ago

@m1kola: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
m1kola commented 3 months ago

E2E jobs is green. Unholding

/unhold

openshift-bot commented 3 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-olm-operator-container-v4.16.0-202405011759.p0.gd998a86.assembly.stream.el9 for distgit ose-cluster-olm-operator. All builds following this will include this PR.