search

openshift / cluster-olm-operator

OpenShift operator that manages the Operator Lifecycle Manager components
Apache License 2.0
0 stars 20 forks source link

AUTH-482: set required-scc for openshift workloads #54

Closed liouk closed 2 months ago

liouk commented 2 months ago

Description of the change:

This PR explicitly sets the required SCC to be used to admit pods of the cluster-olm-operator deployment. The SCC chosen is the one that the pods are already getting admitted with, which means that this brings no change to the SCC used.

Motivation for the change:

In some cases, custom SCCs can have higher priority than default SCCs, which means that they will be chosen over the default ones. This can lead to unexpected results; in order to protect openshift workloads from this, we must explicitly pin the required SCC to all our workloads in order to make sure that the expected one will be used.

openshift-ci-robot commented 2 months ago

@liouk: This pull request references AUTH-482 which is a valid jira issue.

In response to [this](https://github.com/openshift/cluster-olm-operator/pull/54): >#### Description of the change: > >This PR explicitly sets the required SCC to be used to admit pods of the `cluster-olm-operator` deployment. The SCC chosen is the one that the pods are already getting admitted with, which means that this brings no change to the SCC used. > >#### Motivation for the change: > >In some cases, custom SCCs can have higher priority than default SCCs, which means that they will be chosen over the default ones. This can lead to unexpected results; in order to protect openshift workloads from this, we must explicitly pin the required SCC to all our workloads in order to make sure that the expected one will be used. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-olm-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 months ago

@liouk: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
kevinrizza commented 2 months ago

/lgtm /approve

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kevinrizza, liouk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-olm-operator/blob/main/OWNERS)~~ [kevinrizza] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-olm-operator-container-v4.16.0-202405100946.p0.g27bf70d.assembly.stream.el9 for distgit ose-cluster-olm-operator. All builds following this will include this PR.