StaticResourcesController does not delete static resources when "cluster" olm object is deleted.

[joelanford]

Not sure if this is intentional in the StaticResourceController logic, or if I've coded our controller incorrectly, but I am not seeing the resources managed by static resource controllers being deleted when the "cluster" olm object is deleted.

I don't think this is a blocker because:

1. We're in TechPreview and don't expect the "cluster" olm object to be deleted in the first place
2. NOT deleting the static resources may be intentional to avoid data loss. Our CRDs are managed by the static resource controllers, so it may actually be desirable to keep those around even when the "cluster" olm object is gone.
3. Re-creating the "cluster" olm object after a deletion does not seem to cause any problems. The controller finds the existing objects and resumes managing them.

One slightly undesirable thing does happen though. The cluster-olm-operator logs are spammed during resyncs with:

E0626 10:34:38.586824   98752 base_controller.go:268] RukpakStaticResources reconciliation failed: olm.operator.openshift.io "cluster" not found
E0626 10:34:38.586845   98752 base_controller.go:268] CatalogdStaticResources reconciliation failed: olm.operator.openshift.io "cluster" not found
E0626 10:34:38.587920   98752 base_controller.go:268] OperatorControllerStaticResources reconciliation failed: olm.operator.openshift.io "cluster" not found

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[ncdc]

/lifecycle frozen