openshift / cluster-operator

52 stars 35 forks source link

Refactor for cloud provider specific provider configs. #267

Closed dgoodwin closed 6 years ago

dgoodwin commented 6 years ago

Stop using ClusterDeploymentSpec for both ClusterDeployment.Spec and Cluster.Spec.ProviderConfig. Similar for status.

ClusterDeployment had a full copy of the status that was never set or used. Conditions remain for cluster version conditions.

Removed unused fields such as machine set count, and master/infra machine set names.

Limited cluster version info, in the provider config, to just what is necessary for a cluster.

Added concept of distribution config, which we may push for upstream as a separate field.

dgoodwin commented 6 years ago

Ok all feedback addressed. I was able to get "mostly" through an e2e test, my remote machines did not seem to get actuated even though their machinesets/machines in etcd were created in remote cluster. Did not have time to dig into this yet. Deprovision worked smoothly.

dgoodwin commented 6 years ago

I think this is ready now, compute/infra won't create until this merges and we rebuild images.

csrwng commented 6 years ago

Please remove wip from the title so we can merge it.

csrwng commented 6 years ago

Also please squash the commits

dgoodwin commented 6 years ago

Done.

csrwng commented 6 years ago

/lgtm