search

openshift / cluster-operator

52 stars 35 forks source link

Skip remote machineset cleanup when sync never happend #289

Closed csrwng closed 6 years ago

csrwng commented 6 years ago

Fixes issue when clusterdeployment never gets to sync remote machinesets and gets deleted, the finalizer for the remote machinesets remains and doesn't allow the clusterdeployment to be deleted.

csrwng commented 6 years ago

@dgoodwin ptal

dgoodwin commented 6 years ago

This is great, would be great if we could immediately delete a cluster and see it kill off all jobs and clean up everything running, this gets us one step closer.

csrwng commented 6 years ago

Updated

dgoodwin commented 6 years ago

/lgtm

Sounds good to me