search

openshift / cluster-operator

52 stars 35 forks source link

Hookup pod and service network CIDRs in the API. #292

Closed dgoodwin closed 6 years ago

dgoodwin commented 6 years ago

Re-use the cluster-api NetworkConfig struct.

Supports multiple ranges but currently validates that only one is provided, as this appears to be all openshift-ansible supports.

Will default if none is provided.

Once set these values are immutable.

dgoodwin commented 6 years ago

Updated.

csrwng commented 6 years ago

/retest

csrwng commented 6 years ago

@dgoodwin the integration test keeps failing, you may want to look into it

dgoodwin commented 6 years ago

My mistake, forgot to run tests after I added validation to require some of those fields.

csrwng commented 6 years ago

/lgtm