openshift / cluster-operator

52 stars 35 forks source link

aws client setup refactor #310

Closed joelddiaz closed 6 years ago

joelddiaz commented 6 years ago

redo the parameters needed to set up an aws client (needed for other stuff i'm working on) so that it doesn't need to know about the internals of machinesetspec objects.

update controllers and tests using the aws client accordingly

joelddiaz commented 6 years ago

@csrwng i still need to test this once the machine object spec.roles[] changes are settled down, but could use a review on this at this point

dgoodwin commented 6 years ago

Still has a WIP tag, let me know if it's ok to merge.

joelddiaz commented 6 years ago

@dgoodwin i rebased and retested. things look good on my end. removed the WIP

dgoodwin commented 6 years ago

/lgtm