Add route53 hosted zone controller.

twiest commented 6 years ago

[x] Add route53 hosted zone controller.
[x] Add unit tests for route53 hosted zone controller
[x] Add aggregated API for DNSZone object
[x] Verify that controller correctly creates route53 hosted zones given a DNSZone object

twiest commented 6 years ago

@csrwng @dgoodwin Hey Guys, I think this is ready for review.

@csrwng said he'd fix the ci/prow/images CI failure, so I don't think we need to hold up the review for that.

I'm seeing now how massive this PR is, sorry about that. I'd like to talk tomorrow in our stand up about having smaller PRs when writing controllers from scratch. I know Joel's most recent controller was also a very large PR.

AFAIK, no one likes large PRs to review, so I'd like to do better.

Some ideas I have are submit separate PRs for:

DNSZone objects created in the aggregated API and tests
Route53HostedZone controller up and running with unit tests

csrwng commented 6 years ago

Fix for images test failure submitted here: https://github.com/openshift/release/pull/1223

csrwng commented 6 years ago

/test images

twiest commented 6 years ago

@dgoodwin I believe I've addressed all of your comments.

Would you mind reviewing this again for me please?

twiest commented 6 years ago

@dgoodwin Ok, I believe I've address your comments. Please review again to make sure I addressed them properly.

Thanks!

dgoodwin commented 6 years ago

/lgtm

Nice work @twiest

openshift / cluster-operator

Add route53 hosted zone controller. #325