search

openshift / cluster-samples-operator

The samples operator installs+maintains the sample templates+imagestreams on a cluster
29 stars 89 forks source link

WRKLDS-1015: tolerate node-role.kubernetes.io/control-plane:NoExecute #541

Open knelasevero opened 7 months ago

knelasevero commented 7 months ago

Required to be able to advise customers to follow workflow described in https://github.com/openshift/enhancements/pull/1583. If they want to taint control-plane nodes to avoid any other thing to run there (while enforcing it further with validating admission policies), control plane workloads need to tolerate that taint.

openshift-ci-robot commented 7 months ago

@knelasevero: This pull request references WRKLDS-1015 which is a valid jira issue.

In response to [this](https://github.com/openshift/cluster-samples-operator/pull/541): >Required to be able to advise customers to follow workflow described in https://github.com/openshift/enhancements/pull/1583. If they want to taint control-plane nodes to avoid any other thing to run there (while enforcing it further with validating admission policies), control plane workloads need to tolerate that taint. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-samples-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: knelasevero Once this PR has been reviewed and has the lgtm label, please assign gabemontero for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/cluster-samples-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
knelasevero commented 7 months ago

Is there any other place where I would probably need to tolerate the taint in this repo?

openshift-ci[bot] commented 7 months ago

@knelasevero: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-aws-ovn 186a56e6dc7fdfa336a93875307ecfd8fa1b4861 link false /test okd-e2e-aws-ovn
ci/prow/okd-scos-e2e-aws-ovn-image-ecosystem 186a56e6dc7fdfa336a93875307ecfd8fa1b4861 link false /test okd-scos-e2e-aws-ovn-image-ecosystem
ci/prow/okd-scos-e2e-aws-ovn-builds 186a56e6dc7fdfa336a93875307ecfd8fa1b4861 link false /test okd-scos-e2e-aws-ovn-builds
ci/prow/okd-e2e-aws-ovn-builds 186a56e6dc7fdfa336a93875307ecfd8fa1b4861 link false /test okd-e2e-aws-ovn-builds
ci/prow/okd-scos-e2e-aws-ovn 186a56e6dc7fdfa336a93875307ecfd8fa1b4861 link false /test okd-scos-e2e-aws-ovn
ci/prow/okd-e2e-aws-ovn-image-ecosystem 186a56e6dc7fdfa336a93875307ecfd8fa1b4861 link false /test okd-e2e-aws-ovn-image-ecosystem
ci/prow/okd-e2e-aws-ovn-upgrade 186a56e6dc7fdfa336a93875307ecfd8fa1b4861 link false /test okd-e2e-aws-ovn-upgrade
ci/prow/okd-scos-e2e-aws-ovn-upgrade 186a56e6dc7fdfa336a93875307ecfd8fa1b4861 link false /test okd-scos-e2e-aws-ovn-upgrade
ci/prow/okd-e2e-aws-ovn-jenkins 186a56e6dc7fdfa336a93875307ecfd8fa1b4861 link false /test okd-e2e-aws-ovn-jenkins
ci/prow/okd-e2e-aws-operator 186a56e6dc7fdfa336a93875307ecfd8fa1b4861 link false /test okd-e2e-aws-operator
ci/prow/okd-scos-e2e-aws-ovn-jenkins 186a56e6dc7fdfa336a93875307ecfd8fa1b4861 link false /test okd-scos-e2e-aws-ovn-jenkins
ci/prow/okd-scos-e2e-aws-operator 186a56e6dc7fdfa336a93875307ecfd8fa1b4861 link false /test okd-scos-e2e-aws-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
fbm3307 commented 7 months ago

/test e2e-aws-ovn-image-ecosystem

fbm3307 commented 7 months ago

@knelasevero Samples operator is going to be removed After OCP 4.17, we are already into maintenance mode . SO i would not recommend adding anything new to samples operator now

openshift-bot commented 3 months ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot commented 2 months ago

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

metlos commented 2 months ago

/remove-lifecycle rotten /retest