search

openshift / cluster-samples-operator

The samples operator installs+maintains the sample templates+imagestreams on a cluster
29 stars 89 forks source link

AGENT-863: add a new image stream manifest for the fips capable installer #544

Closed andfasano closed 7 months ago

andfasano commented 7 months ago

This patch is required to retrieve the baremetal installer image by the day2 add node script (see https://github.com/openshift/installer/pull/8242)

openshift-ci-robot commented 7 months ago

@andfasano: This pull request references AGENT-863 which is a valid jira issue.

In response to [this](https://github.com/openshift/cluster-samples-operator/pull/544): >This patch is required to retrieve the baremetal installer image by the day2 add node script (see https://github.com/openshift/installer/pull/8242) Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-samples-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
andfasano commented 7 months ago

cc @zaneb

zaneb commented 7 months ago

/lgtm

fbm3307 commented 7 months ago

/hold looks like the imagestream is still not available ? https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_cluster-samples-operator/544/pull-ci-openshift-cluster-samples-operator-master-e2e-aws-ovn-image-ecosystem/1782678785934495744

zaneb commented 7 months ago

Hmm, I can see it even without being logged in: https://quay.io/repository/openshift/origin-baremetal-installer

And I can pull it no problem:

$ podman pull quay.io/openshift/origin-baremetal-installer
Trying to pull quay.io/openshift/origin-baremetal-installer:latest...
Getting image source signatures
Copying blob e6564833bd0b done   | 
Copying blob d8190195889e done   | 
Copying blob 9444bc135ccc done   | 
Copying blob 97da74cc6d8f done   | 
Copying blob b7caac98184d done   | 
Copying blob d3540128d21d done   | 
Copying config c00a0c0cf0 done   | 
Writing manifest to image destination
c00a0c0cf0837eeb50de2a425fa84c918b20d10b65b7ac6673154c0f420b32fa

So it's not one of those private repos where nobody can remember if there is a reason for it to be private :sweat_smile:

I think the issue must be that there is no v4.0 tag in the repo, because the first version of OCP to contain this image was 4.2.

Presumably this all gets overwritten by the CVO anyway? @fbm3307 what would you recommend as the tag to use? 4.2 (first version that exists) or e.g. 4.16 (first version that will have the ImageStream) or something else?

fbm3307 commented 7 months ago

i wont be the right person to answer it, i do not have much idea onto the tags.

andfasano commented 7 months ago

Let's go with the latest

andfasano commented 7 months ago

/hold cancel

@fbm3307 looks like the stream is ok now, can we proceed? Thanks

zaneb commented 7 months ago

/retest

openshift-ci[bot] commented 7 months ago

@andfasano: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-operator 120c58b5a7dfdc8487359cb4d75bbf82c5d35398 link false /test okd-scos-e2e-aws-operator
ci/prow/okd-scos-e2e-aws-ovn-upgrade 120c58b5a7dfdc8487359cb4d75bbf82c5d35398 link false /test okd-scos-e2e-aws-ovn-upgrade
ci/prow/okd-e2e-aws-ovn-jenkins 120c58b5a7dfdc8487359cb4d75bbf82c5d35398 link false /test okd-e2e-aws-ovn-jenkins
ci/prow/okd-scos-e2e-aws-ovn-image-ecosystem 120c58b5a7dfdc8487359cb4d75bbf82c5d35398 link false /test okd-scos-e2e-aws-ovn-image-ecosystem
ci/prow/okd-scos-e2e-aws-ovn 120c58b5a7dfdc8487359cb4d75bbf82c5d35398 link false /test okd-scos-e2e-aws-ovn
ci/prow/okd-e2e-aws-ovn-builds 120c58b5a7dfdc8487359cb4d75bbf82c5d35398 link false /test okd-e2e-aws-ovn-builds
ci/prow/okd-e2e-aws-ovn 120c58b5a7dfdc8487359cb4d75bbf82c5d35398 link false /test okd-e2e-aws-ovn
ci/prow/okd-scos-e2e-aws-ovn-builds 120c58b5a7dfdc8487359cb4d75bbf82c5d35398 link false /test okd-scos-e2e-aws-ovn-builds
ci/prow/okd-e2e-aws-ovn-image-ecosystem 120c58b5a7dfdc8487359cb4d75bbf82c5d35398 link false /test okd-e2e-aws-ovn-image-ecosystem
ci/prow/okd-e2e-aws-ovn-upgrade 120c58b5a7dfdc8487359cb4d75bbf82c5d35398 link false /test okd-e2e-aws-ovn-upgrade
ci/prow/okd-e2e-aws-operator 120c58b5a7dfdc8487359cb4d75bbf82c5d35398 link false /test okd-e2e-aws-operator
ci/prow/okd-scos-e2e-aws-ovn-jenkins 120c58b5a7dfdc8487359cb4d75bbf82c5d35398 link false /test okd-scos-e2e-aws-ovn-jenkins

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
zaneb commented 7 months ago

All passing except for the optional OKD jobs that have been permafailing for a while now. /lgtm

openshift-ci[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: andfasano, zaneb Once this PR has been reviewed and has the lgtm label, please assign gabemontero for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/cluster-samples-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
fbm3307 commented 7 months ago

Just FYI @zaneb @andfasano , Samples operator is going to be removed After OCP 4.17, we are already into maintenance mode . SO i would not recommend adding anything new to samples operator now

andfasano commented 7 months ago

Closed as per comment https://github.com/openshift/cluster-samples-operator/pull/544#issuecomment-2074406605