search

openshift / cluster-samples-operator

The samples operator installs+maintains the sample templates+imagestreams on a cluster
29 stars 89 forks source link

NO-ISSUE: Only pick up the changes from the supported imagestreams and templates in library-sync.sh. #553

Closed metlos closed 3 months ago

metlos commented 3 months ago

This updates the library-sync.sh script to only update the imagestreams and templates of the supported samples.

This should ease the release process so that we (or any future maintainer) doesn't have to remember to manually go through the changes brought in from openshift and remove any changes to the unsupported samples.

openshift-ci[bot] commented 3 months ago

Hi @metlos. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
fbm3307 commented 3 months ago

/ok-to-test

fbm3307 commented 3 months ago

/lgtm

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fbm3307, metlos, mfrancisc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-samples-operator/blob/master/OWNERS)~~ [fbm3307,mfrancisc] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
fbm3307 commented 3 months ago

/test okd-images

metlos commented 3 months ago

/retest-required

bradmwilliams commented 3 months ago

/test okd-scos-images

jupierce commented 3 months ago

/test e2e-aws-ovn-proxy

jupierce commented 3 months ago

/retest

openshift-ci-robot commented 3 months ago

@metlos: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/cluster-samples-operator/pull/553): >This updates the `library-sync.sh` script to only update the imagestreams and templates of the supported samples. > >This should ease the release process so that we (or any future maintainer) doesn't have to remember to manually go through the changes brought in from openshift and remove any changes to the unsupported samples. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-samples-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jupierce commented 3 months ago

I don't see any need for docs/px in this PR, and a request was made to land this. So adding required labels.

jupierce commented 3 months ago

Overriding old okd jobs: /override ci/prow/okd-e2e-aws-ovn-builds /override ci/prow/okd-e2e-aws-ovn-image-ecosystem /override ci/prow/okd-e2e-aws-ovn-upgrade /override ci/prow/okd-e2e-aws-operator /override ci/prow/okd-e2e-aws-ovn /override ci/prow/okd-e2e-aws-ovn-jenkins /override ci/prow/okd-images

openshift-ci[bot] commented 3 months ago

@jupierce: Overrode contexts on behalf of jupierce: ci/prow/okd-e2e-aws-operator, ci/prow/okd-e2e-aws-ovn, ci/prow/okd-e2e-aws-ovn-builds, ci/prow/okd-e2e-aws-ovn-image-ecosystem, ci/prow/okd-e2e-aws-ovn-jenkins, ci/prow/okd-e2e-aws-ovn-upgrade, ci/prow/okd-images

In response to [this](https://github.com/openshift/cluster-samples-operator/pull/553#issuecomment-2278567323): >Overriding old okd jobs: >/override ci/prow/okd-e2e-aws-ovn-builds >/override ci/prow/okd-e2e-aws-ovn-image-ecosystem >/override ci/prow/okd-e2e-aws-ovn-upgrade >/override ci/prow/okd-e2e-aws-operator >/override ci/prow/okd-e2e-aws-ovn >/override ci/prow/okd-e2e-aws-ovn-jenkins >/override ci/prow/okd-images Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 3 months ago

@metlos: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
jupierce commented 3 months ago

/cherry-pick release-4.17

openshift-cherrypick-robot commented 3 months ago

@jupierce: new pull request created: #560

In response to [this](https://github.com/openshift/cluster-samples-operator/pull/553#issuecomment-2278578430): >/cherry-pick release-4.17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 3 months ago

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-samples-operator This PR has been included in build ose-cluster-samples-operator-container-v4.18.0-202408092013.p0.g5a71cf6.assembly.stream.el9. All builds following this will include this PR.

ausil commented 2 months ago

I think this has actually made the release process harder by leaving the unsupported image streams in whatever state they are in. Any changes in the library will never get reflected, leading to bitrot, which is what has broken OKD for all releases. trying to remove the unsupported imagestreams turns out to be very difficult because there are tests in various places expecting them. We should either remove the ticking time bomb that is leaving things in an indeterminate state that may change out from under us, by removing any imagestreams that are unsupported and dealing with the CI fallout, or we need to keep syncing all things from library.

Prashanth684 commented 2 months ago

There are references to mysql in the origin repo. eg: https://github.com/openshift/origin/blob/master/test/extended/util/framework.go#L315. these need to be cleaned up if these streams are not going to be supported anymore