search

openshift / cluster-samples-operator

The samples operator installs+maintains the sample templates+imagestreams on a cluster
29 stars 89 forks source link

OCPBUGS-38994: Fix library-sync.sh to handle renames in unsupported samples #562

Closed metlos closed 2 months ago

metlos commented 2 months ago

Improve the handling of changes in the unsupported samples so that no traces are left behind even when files were renamed or moved to a different location.

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metlos, mfrancisc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-samples-operator/blob/master/OWNERS)~~ [metlos,mfrancisc] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 2 months ago

@metlos: This pull request references Jira Issue OCPBUGS-38994, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @jitendar-singh

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-samples-operator/pull/562): >Improve the handling of changes in the unsupported samples so that no traces are left behind even when files were renamed or moved to a different location. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-samples-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
metlos commented 2 months ago

/label acknowledge-critical-fixes-only

openshift-ci-robot commented 2 months ago

/retest-required

Remaining retests: 0 against base HEAD 5da50fff9d8b990f016548d913a061955f20e6c4 and 2 for PR HEAD c863d2b31b2daacac933d0c748fd53c1a9ee27e7 in total

metlos commented 2 months ago

/restest

metlos commented 2 months ago

/test e2e-aws-operator

metlos commented 2 months ago

/test e2e-aws-operator

metlos commented 2 months ago

/test e2e-aws-operator

metlos commented 2 months ago

/cherry-pick release-4.17

openshift-cherrypick-robot commented 2 months ago

@metlos: once the present PR merges, I will cherry-pick it on top of release-4.17 in a new PR and assign it to you.

In response to [this](https://github.com/openshift/cluster-samples-operator/pull/562#issuecomment-2312911168): >/cherry-pick release-4.17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 2 months ago

/retest-required

Remaining retests: 0 against base HEAD 5da50fff9d8b990f016548d913a061955f20e6c4 and 2 for PR HEAD c863d2b31b2daacac933d0c748fd53c1a9ee27e7 in total

openshift-ci-robot commented 2 months ago

/retest-required

Remaining retests: 0 against base HEAD 5da50fff9d8b990f016548d913a061955f20e6c4 and 2 for PR HEAD c863d2b31b2daacac933d0c748fd53c1a9ee27e7 in total

openshift-ci[bot] commented 2 months ago

@metlos: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 2 months ago

@metlos: Jira Issue OCPBUGS-38994: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-38994 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-samples-operator/pull/562): >Improve the handling of changes in the unsupported samples so that no traces are left behind even when files were renamed or moved to a different location. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-samples-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-cherrypick-robot commented 2 months ago

@metlos: new pull request created: #565

In response to [this](https://github.com/openshift/cluster-samples-operator/pull/562#issuecomment-2312911168): >/cherry-pick release-4.17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-samples-operator This PR has been included in build ose-cluster-samples-operator-container-v4.18.0-202408272341.p0.gf3300e2.assembly.stream.el9. All builds following this will include this PR.