search

openshift / cluster-samples-operator

The samples operator installs+maintains the sample templates+imagestreams on a cluster
29 stars 89 forks source link

OCPBUGS-42265: Fix the rails template before the upstream accepts or PR #574

Closed metlos closed 2 months ago

metlos commented 2 months ago

Fix the rails template before the upstream accepts our PR (https://github.com/sclorg/rails-ex/pull/178).

metlos commented 2 months ago

/test

openshift-ci[bot] commented 2 months ago

@metlos: The /test command needs one or more targets. The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/openshift/cluster-samples-operator/pull/574#issuecomment-2363964199): >/test Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
metlos commented 2 months ago

/test all

openshift-ci-robot commented 2 months ago

@metlos: This pull request references Jira Issue OCPBUGS-42265, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @jitendar-singh

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-samples-operator/pull/574): >Fix the rails template before the upstream accepts our PR (https://github.com/sclorg/rails-ex/pull/178). Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-samples-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
fbm3307 commented 2 months ago

/lgtm

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fbm3307, metlos

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-samples-operator/blob/master/OWNERS)~~ [fbm3307,metlos] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 2 months ago

/retest-required

Remaining retests: 0 against base HEAD e75691199596a76d81491027b91636afaa7b3a47 and 2 for PR HEAD cccebd3ced1f2e461f88c1469f96116db2898b2e in total

openshift-ci-robot commented 2 months ago

/retest-required

Remaining retests: 0 against base HEAD e75691199596a76d81491027b91636afaa7b3a47 and 2 for PR HEAD cccebd3ced1f2e461f88c1469f96116db2898b2e in total

metlos commented 2 months ago

I am going to override the image ecosystem test so that our changes in https://github.com/openshift/origin/pull/29116 have a chance to pass.

Currently we're in a Head-22 situation with these PRs.

The image ecosystem test in this PR uses the master of CI in openshift/origin that looks for a DeploymentConfig in Rails and uses perl:5.30-el7 for the Perl test. This won't pass because Rails now uses Deployment and per:5.30-el7 is not available anymore.

On the other hand, https://github.com/openshift/origin/pull/29116 will not pass until we fix the rails templates in this PR.

metlos commented 2 months ago

/override ci/prow/e2e-aws-ovn-image-ecosystem

openshift-ci[bot] commented 2 months ago

@metlos: Overrode contexts on behalf of metlos: ci/prow/e2e-aws-ovn-image-ecosystem

In response to [this](https://github.com/openshift/cluster-samples-operator/pull/574#issuecomment-2364581849): >/override ci/prow/e2e-aws-ovn-image-ecosystem Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 2 months ago

@metlos: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 2 months ago

@metlos: Jira Issue OCPBUGS-42265: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-42265 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-samples-operator/pull/574): >Fix the rails template before the upstream accepts our PR (https://github.com/sclorg/rails-ex/pull/178). Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-samples-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-samples-operator This PR has been included in build ose-cluster-samples-operator-container-v4.18.0-202409202309.p0.g21a101b.assembly.stream.el9. All builds following this will include this PR.