openshift / cluster-samples-operator

The samples operator installs+maintains the sample templates+imagestreams on a cluster
29 stars 89 forks source link

OKD-225: remove only the EOL CentOS 7 images #575

Closed ausil closed 1 month ago

ausil commented 2 months ago

Remove all references to the EOL CentOS 7 images that have been removed, update the redis image to a scl.org c9s one, as the CentOS 7 one was the only one available

openshift-ci-robot commented 2 months ago

@ausil: This pull request references OKD-225 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-samples-operator/pull/575): >Remove all references to the EOL CentOS 7 images that have been removed, update the redis image to a scl.org c9s one, as the CentOS 7 one was the only one available Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-samples-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
ausil commented 2 months ago

@metlos this is I think the smallest change we could make to get 4.17 moving again

Prashanth684 commented 2 months ago

/retest

openshift-ci[bot] commented 2 months ago

@ausil: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
ausil commented 1 month ago

/assign adambkaplan

Prashanth684 commented 1 month ago

/lgtm

metlos commented 1 month ago

/approve /lgtm

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ausil, metlos, Prashanth684

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-samples-operator/blob/release-4.17/OWNERS)~~ [metlos] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Prashanth684 commented 1 month ago

/cherry-pick release-4.16

openshift-cherrypick-robot commented 1 month ago

@Prashanth684: new pull request created: #576

In response to [this](https://github.com/openshift/cluster-samples-operator/pull/575#issuecomment-2368755212): >/cherry-pick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-samples-operator This PR has been included in build ose-cluster-samples-operator-container-v4.17.0-202409231736.p0.gfde847e.assembly.stream.el9. All builds following this will include this PR.