openshift / cluster-samples-operator

The samples operator installs+maintains the sample templates+imagestreams on a cluster
29 stars 89 forks source link

SO-137: Support updating the library separately for OKD and for OCP. #581

Closed metlos closed 1 month ago

metlos commented 1 month ago

This changes library-sync.sh such that by default, it only updates the supported samples in OCP for all architectures.

If the --okd parameter is supplied to the script, all samples in OKD are updated (there are no unsupported samples in OKD).

openshift-ci-robot commented 1 month ago

@metlos: This pull request references SO-137 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-samples-operator/pull/581): >This changes `library-sync.sh` such that by default, it only updates the supported samples in OCP for all architectures. > >If the `--okd` parameter is supplied to the script, all samples in OKD are updated (there are no unsupported samples in OKD). Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-samples-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
metlos commented 1 month ago

@Prashanth684 does this look likes something that would improve our "release experience" the next time?

For OKD, you'd run ./library-sync.sh --okd which would update all the samples in OKD (not resetting any "unsupported" ones).

openshift-ci[bot] commented 1 month ago

@metlos: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
mfrancisc commented 1 month ago

/lgtm

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metlos, mfrancisc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-samples-operator/blob/master/OWNERS)~~ [metlos,mfrancisc] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-samples-operator This PR has been included in build ose-cluster-samples-operator-container-v4.18.0-202410150841.p0.gd98a041.assembly.stream.el9. All builds following this will include this PR.