search

openshift / community

Community organizational documentations and process for OKD
61 stars 29 forks source link

Adding myself as a member #16

Closed SafPlusPlus closed 5 years ago

SafPlusPlus commented 5 years ago

/assign @danyc97

DanyC97 commented 5 years ago

@SafPlusPlus you mind fixing the conflict please ?

@LorbusChris and i realized after the charter was out that firing a PR process will cause this issue however we didn't want to pull and change the charter. We'll follow up after it gets merged.

What we should have done was to ask folks to create a github issue in this repo and either @LorbusChris or i would have created the PR and merge it to avoid asking you to rebase, sorry for inconvenience ... we are learning as we go and will try to adjust/ imrpove the process

DanyC97 commented 5 years ago

/lgtm /approve

openshift-ci-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DanyC97, SafPlusPlus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/community/blob/master/OWNERS)~~ [DanyC97] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
DanyC97 commented 5 years ago

/close

in favour of #29 reason - see #19

openshift-ci-robot commented 5 years ago

@DanyC97: Closed this PR.

In response to [this](https://github.com/openshift/community/pull/16#issuecomment-528804195): >/close > >in favour of #29 >reason - see #19 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.