Closed JAORMX closed 3 years ago
Pull-request updated, HEAD is now 3795576cb75ff60f4b6b9c17248d4db36bd5d41e
Pull-request updated, HEAD is now f25aedebc65b47349684164bff3d16491571e63d
Pull-request updated, HEAD is now 49b284b000fdc93ad5a6f10fb68f6c002cb290fe
Pull-request updated, HEAD is now 281b0048196b762bce2ac18c5ac310beb279ad6e
Pull-request updated, HEAD is now 9f33795a7fc59432031c8984058d6278cd45d918
/retest
Pull-request updated, HEAD is now 3c4160967cd10a0745fcb8e7275798832a44ad30
Pull-request updated, HEAD is now 33fa74430ce298986c98d406799bcc5a5c315cb6
/test all
Just the one small nit, and it LGTM
Pull-request updated, HEAD is now a515bb0cffd8d79ce539da3323e750a533067839
@Vincent056: changing LGTM is restricted to collaborators
/bugzilla cc-qa
@xiaojiey: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh
.
per test result http://pastebin.test.redhat.com/991689, the PR looks good to me. /lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: JAORMX, Vincent056, xiaojiey
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/label qe-approved
This removes the requirement of having to extend a Profile in order to create a TailoredProfile. So, the
extends
field from the TailoredProfile CRD is no longer mandatory.This requires for users to only select rules from the same ProfileBundle, as the ProfileBundle will become "owner" of the TailoredProfile object (for garbage collection reasons).
Also, TailoredProfiles now require the following annotation (which is currently used by Profiles):
If left unset, the default will be
Platform
.If the TailoredProfile's name ends with the suffix
-node
, the annotation will have the valueNode
, and will schedule aNode
scan type instead.If the annotation is set, it's left untouched.
This is a little manual right now, but can be extended in the future.
The ScanSettigBinding controller will also now wait for a TailoredProfile object to be parsed and ready before trying to create a ComplianceSuite.
Closes https://github.com/openshift/compliance-operator/issues/628