search

openshift / compliance-operator

Operator providing OpenShift cluster compliance checks
Apache License 2.0
110 stars 110 forks source link

e2e: Migrate TestScanProducesRemediations to use ScanSettingBinding #697

Closed JAORMX closed 3 years ago

JAORMX commented 3 years ago

This migrates the test to use ScanSettingBindings and TailoredProfiles, which is what we recommend users do. It also stops using the rhcos4-moderate profile which is very time and resource intensive, and instead uses the ocp4-moderate which is quite complete but lighter.

The profile change also fixes a fluke. The moderate profile doesn't produce all remediations with the "applicable" state, as some need dependencies. So we couldn't even do this test properly with that profile anyway. So the profile change is needed.

Signed-off-by: Juan Antonio Osorio Robles jaosorior@redhat.com

JAORMX commented 3 years ago

Pull-request updated, HEAD is now 5c1b2fc9b324a08178d0db3c8ed11512329cfaed

openshift-ci[bot] commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JAORMX, jhrozek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/compliance-operator/blob/master/OWNERS)~~ [JAORMX,jhrozek] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment