search

openshift / compliance-operator

Operator providing OpenShift cluster compliance checks
Apache License 2.0
110 stars 110 forks source link

aggregator: Remove MachineConfig validation #715

Closed JAORMX closed 3 years ago

JAORMX commented 3 years ago

we don't need to do this in the aggregator, the validation is ran anyway on the remediation controller. This way we can actually show to the user why a MachineConfig remediation wasn't able to be created.

With this, the aggregator is just a "simple" program that aggregated and creates remediations, no extra magic.

Signed-off-by: Juan Antonio Osorio Robles jaosorior@redhat.com

Vincent056 commented 3 years ago

I think it is a good approach to leave that handling to the remediation controller, It /lgtm !

openshift-ci[bot] commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JAORMX, jhrozek, Vincent056

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/compliance-operator/blob/master/OWNERS)~~ [JAORMX,jhrozek] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment