search

openshift / compliance-operator

Operator providing OpenShift cluster compliance checks
Apache License 2.0
110 stars 110 forks source link

Add variable support for non-urlencoded content #727

Closed Vincent056 closed 3 years ago

Vincent056 commented 3 years ago

Since not all remediation templating are URL-encoded, we need different processing for those remediation that does not have URL-encoded content. This Pr is for KubeletConfig remediation, since KubeletConfig is not URL-encoded, and we need to use variable template.

ex. {{.var_some_value}} is not URL-encoded, we just need to replace the value

openshift-ci[bot] commented 3 years ago

Hi @Vincent056. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
JAORMX commented 3 years ago

/ok-to-test

Vincent056 commented 3 years ago

/retest

JAORMX commented 3 years ago 
     helpers.go:276: couldn't update scan to re-launch it: compliancescans.compliance.openshift.io "audit-profile-set-test-e2e" not found
Vincent056 commented 3 years ago 
     helpers.go:276: couldn't update scan to re-launch it: compliancescans.compliance.openshift.io "audit-profile-set-test-e2e" not found

Thanks for pointing it out, I just fixed the name

JAORMX commented 3 years ago

/lgtm

openshift-ci[bot] commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JAORMX, Vincent056

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/compliance-operator/blob/master/OWNERS)~~ [JAORMX] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment