openshift / compliance-operator

Operator providing OpenShift cluster compliance checks
Apache License 2.0
110 stars 110 forks source link

Create a kubeletconfig per pool #732

Closed JAORMX closed 3 years ago

JAORMX commented 3 years ago

The kubeletconfig remediations were working as a singleton per cluster, but we really want to fix them per pool (this is the way we can apply them via the MCO).

This fixes that by appending the pool name to the kubeletconfig remediation we generate.

Signed-off-by: Juan Antonio Osorio Robles jaosorior@redhat.com

JAORMX commented 3 years ago

Pull-request updated, HEAD is now 42685904c198ee5556e728b67c601e2b9252bcd9

JAORMX commented 3 years ago

/retest

cluster setup error

Vincent056 commented 3 years ago

Thanks for the PR! This /lgtm

Vincent056 commented 3 years ago

/retest

openshift-ci[bot] commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JAORMX, jhrozek, Vincent056

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/compliance-operator/blob/master/OWNERS)~~ [JAORMX,jhrozek] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
JAORMX commented 3 years ago

/retest

JAORMX commented 3 years ago

/retest

JAORMX commented 3 years ago

/test all

JAORMX commented 3 years ago

/test all

JAORMX commented 3 years ago

/test all