search

openshift / compliance-operator

Operator providing OpenShift cluster compliance checks
Apache License 2.0
110 stars 110 forks source link

Result Server: Make nodeSelector and tolerations configurable #733

Closed JAORMX closed 3 years ago

JAORMX commented 3 years ago

This makes the aforementioned parameters configurable through the ScanSettings object.

This enables deployers to configure where the Result Server will run, and thus what node will host the Persistent Volume that will contain the raw results.

This is needed for cases where the storage driver doesn't allow us to schedule a pod that makes use of a persistent volume on the master nodes.

Signed-off-by: Juan Antonio Osorio Robles jaosorior@redhat.com

JAORMX commented 3 years ago

/hold

Waiting for @pdhamdhe 's feedback

JAORMX commented 3 years ago

/assign @pdhamdhe

JAORMX commented 3 years ago

/retest

JAORMX commented 3 years ago

/retest

JAORMX commented 3 years ago

/test all

pdhamdhe-zz commented 3 years ago

/approve /hold cancel

pdhamdhe-zz commented 3 years ago

The nodeSelector and tolerations configurable for result server pod and it works fine. Here is testing details recorded for reference

openshift-ci[bot] commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JAORMX, mrogers950, pdhamdhe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/compliance-operator/blob/master/OWNERS)~~ [JAORMX,mrogers950,pdhamdhe] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment