Closed rhmdnd closed 2 years ago
There is still a lot of things to clean up here, but this is a rough draft of where I got today.
Thanks for the PR, I think this PR looks much cleaner than the last one, so we would only need to maintain
deploy/compliance-operator-chart/templates/deployment.yaml
,deploy/compliance-operator-chart/templates/scansettingbinding.yaml
, and those default values?
I was trying out this PR, saw
[vincent@fedora-ws compliance-operator-chart]$ helm install --namespace openshift-compliance --generate-name .
WARNING: Kubernetes configuration file is group-readable. This is insecure. Location: /home/vincent/.ocp-clusters/cluster-deploy-wenshen-51//auth/kubeconfig
Error: template: compliance-operator-chart/templates/deployment.yaml:4:11: executing "compliance-operator-chart/templates/deployment.yaml" at <include "compliance-operator-chart.fullname" .>: error calling include: template: no template "compliance-operator-chart.fullname" associated with template "gotpl"
Do you think I missed something?
Nope - you're right. I forgot to include the _helpers.tpl
. I updated the PR, it should be there if you try it again.
Correct. The CRDs are symlink'd to the existing location in deploy/crds/
. The majority of what we will have to maintain is in the templates directory and the default values.
@rhmdnd LGTM, if you can squash the commits, I'm OK with merging it.
Done - thanks for the reviews.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: rhmdnd, Vincent056
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/retest
/retest
@rhmdnd: all tests passed!
Full PR test history. Your PR dashboard.
/lgtm
As we integrate support for deploying the compliance operator on other distributions (like EKS), we can't guarantee users will install using the OLM or OperatorHub. At the same time, we can try to provide something better than installing from source.
This commit introduces a helm chart that deploys the compliance-operator.