search

openshift / compliance-operator

Operator providing OpenShift cluster compliance checks
Apache License 2.0
110 stars 110 forks source link

Bug 2040401: fix can't find owner of 98-<pool>-generated-kubelet #775

Closed Vincent056 closed 2 years ago

Vincent056 commented 2 years ago

the vsphere-upi installer created some kubelet configuration files 98-<pool>-generated-kubelet, and they were recognized as kubeletconfig generated mc by CO, to fix that we added an additional check to check if the prefix of kubelet mc have 99-. since the custom kubeletconfig will always generate mc with name scheme 99-<pool>-generated-kubelet-<num>

Related Bugzilla Link: https://bugzilla.redhat.com/show_bug.cgi?id=2040401

openshift-ci[bot] commented 2 years ago

@Vincent056: This pull request references Bugzilla bug 2040401, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target release (4.10.0) matches configured target release for branch (4.10.0) * bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (pdhamdhe@redhat.com), skipping review request.

In response to [this](https://github.com/openshift/compliance-operator/pull/775): >Bug 2040401: fix can't find owner of 98--generated-kublet Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Vincent056

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/compliance-operator/blob/master/OWNERS)~~ [Vincent056] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 2 years ago

@Vincent056: This pull request references Bugzilla bug 2040401, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target release (4.10.0) matches configured target release for branch (4.10.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (pdhamdhe@redhat.com), skipping review request.

In response to [this](https://github.com/openshift/compliance-operator/pull/775): >Bug 2040401: fix can't find owner of 98--generated-kubelet Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 2 years ago

@Vincent056: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
rhmdnd commented 2 years ago

/lgtm

openshift-ci[bot] commented 2 years ago

@Vincent056: All pull requests linked via external trackers have merged:

Bugzilla bug 2040401 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/compliance-operator/pull/775): >Bug 2040401: fix can't find owner of 98--generated-kubelet Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.