search

openshift / compliance-operator

Operator providing OpenShift cluster compliance checks
Apache License 2.0
110 stars 110 forks source link

Reconcile ScanSettingBindings when a TailoredProfile changes #792

Closed jhrozek closed 2 years ago

jhrozek commented 2 years ago

Modifies the ScanSettingBinding controller to also watch for TailoredProfile CRs which link to a TP. This allows to reconcile ScanSettingBindings in case a TailoredProfile is modified, typically after fixing issues in a TailoredProfile without having to recreate the TailoredProfile.

Fixes: #791

NOTE: I haven't had the chance to test the e2e addition at all. Feedback is welcome in the meantime and maybe the tests will even pass :-)

Vincent056 commented 2 years ago

/retest

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhrozek, Vincent056

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/compliance-operator/blob/master/OWNERS)~~ [Vincent056,jhrozek] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jhrozek commented 2 years ago

/retest

openshift-ci[bot] commented 2 years ago

@jhrozek: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
Vincent056 commented 2 years ago

/lgtm