search

openshift / compliance-operator

Operator providing OpenShift cluster compliance checks
Apache License 2.0
110 stars 110 forks source link

Other arch images #795

Closed gquillar closed 2 years ago

gquillar commented 2 years ago

Build the images according to the architecture to allow the support of other arches. The change has been tested to generate ppc64le and s390x images.

openshift-ci[bot] commented 2 years ago

Hi @gquillar. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
jhrozek commented 2 years ago

/ok-to-test

openshift-ci[bot] commented 2 years ago

@gquillar: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
gquillar commented 2 years ago

/retest

gquillar commented 2 years ago

@jhrozek still pending though your LGTM. What is expected?

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gquillar, jhrozek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/compliance-operator/blob/master/OWNERS)~~ [jhrozek] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jhrozek commented 2 years ago

@jhrozek still pending though your LGTM. What is expected?

I was just giving time for someone else who'd like to ack the patch. Should go through now.

skuethe commented 2 years ago

looking forward for this PR to hit the (next) release, so we can start using it. Any idea when that will be?