CONSOLE-3349: Update plugin template with ConsolePlugin v1 API changes

openshift / console-plugin-template

Minimal template for writing OpenShift console plugins

Apache License 2.0

37 stars 47 forks source link

CONSOLE-3349: Update plugin template with ConsolePlugin v1 API changes #25

Closed jhadvig closed 1 year ago

jhadvig commented 1 year ago

This PR bumps the console-plugin-template from APIversion v1alpha1 to v1.

Tested locally:

/assign @spadgett

openshift-ci-robot commented 1 year ago

@jhadvig: This pull request references CONSOLE-3349 which is a valid jira issue.

In response to [this](https://github.com/openshift/console-plugin-template/pull/25): >This PR bumps the `console-plugin-template` from APIversion `v1alpha1` to `v1`. > >Tested locally: > Screenshot 2023-03-28 at 13 38 39

> >

> >/assign @spadgett > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

jhadvig commented 1 year ago

@spadgett I've created release-4.11 branch that is tracking current master. Also updated the README accordingly. PTAL

spadgett commented 1 year ago

@spadgett I've created release-4.11 branch that is tracking current master. Also updated the README accordingly. PTAL

@jhadvig Thanks. When you say tracking, is it still being synced? We wouldn't want the changes in this PR to go to release-4.11. IIRC the v1 API was only available in 4.12.

jhadvig commented 1 year ago

@jhadvig Thanks. When you say tracking, is it still being synced? We wouldn't want the changes in this PR to go to release-4.11. IIRC the v1 API was only available in 4.12.

right, both release-4.10 and release-4.11 wont contain this change, only main branch