search

openshift / console-plugin-template

Minimal template for writing OpenShift console plugins
Apache License 2.0
40 stars 51 forks source link

OCPBUGS-11042: Remove explicit any type #29

Closed jhadvig closed 1 year ago

jhadvig commented 1 year ago

/assign @cyril-ui-developer

openshift-ci-robot commented 1 year ago

@jhadvig: This pull request references Jira Issue OCPBUGS-11042, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/console-plugin-template/pull/29): >/assign @cyril-ui-developer Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
jhadvig commented 1 year ago

/jira refresh

openshift-ci-robot commented 1 year ago

@jhadvig: This pull request references Jira Issue OCPBUGS-11042, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.14.0) matches configured target version for branch (4.14.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @yapei

In response to [this](https://github.com/openshift/console-plugin-template/pull/29#issuecomment-1503303522): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
cyril-ui-developer commented 1 year ago

/lgtm

Thanks for the fix. Actually, I was thinking of what type I could use instead of any. Make sense to remove them.

openshift-ci-robot commented 1 year ago

@jhadvig: Jira Issue OCPBUGS-11042: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-11042 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/console-plugin-template/pull/29): >/assign @cyril-ui-developer Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.