search

openshift / console-plugin-template

Minimal template for writing OpenShift console plugins
Apache License 2.0
40 stars 51 forks source link

OCPBUGS-10850: Enable source maps for typescript #44

Closed TheRealJon closed 1 year ago

TheRealJon commented 1 year ago

Webpack is configured to generate source maps for development builds, but typescript was not. Update tsconfig.json to enable source maps. Also, add yarn-error.log to .gitignore.

openshift-ci-robot commented 1 year ago

@TheRealJon: This pull request references Jira Issue OCPBUGS-10850, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/console-plugin-template/pull/44): >Webpack is configured to generate source maps for development builds, but typescript was not. Update tsconfig.json to enable source maps. Also, add yarn-error.log to .gitignore. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
TheRealJon commented 1 year ago

/jira refresh

openshift-ci-robot commented 1 year ago

@TheRealJon: This pull request references Jira Issue OCPBUGS-10850, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.14.0) matches configured target version for branch (4.14.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @yapei

In response to [this](https://github.com/openshift/console-plugin-template/pull/44#issuecomment-1561243937): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spadgett, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/console-plugin-template/blob/main/OWNERS)~~ [spadgett] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
TheRealJon commented 1 year ago

/retest

jhadvig commented 1 year ago

/hold Looks like the integration test is failing - Created https://issues.redhat.com/browse/OCPBUGS-14081

TheRealJon commented 1 year ago

/retest

TheRealJon commented 1 year ago

/retest

TheRealJon commented 1 year ago

/retest

jhadvig commented 1 year ago

/retest

jhadvig commented 1 year ago

/hold cancel

openshift-ci[bot] commented 1 year ago

@TheRealJon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 1 year ago

@TheRealJon: Jira Issue OCPBUGS-10850: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-10850 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/console-plugin-template/pull/44): >Webpack is configured to generate source maps for development builds, but typescript was not. Update tsconfig.json to enable source maps. Also, add yarn-error.log to .gitignore. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.