search

openshift / console-plugin-template

Minimal template for writing OpenShift console plugins
Apache License 2.0
37 stars 47 forks source link

OCPBUGS-17824: The test that checks if i18n translations are up to date doesn't fail after i18n changes #50

Closed Mylanos closed 11 months ago

Mylanos commented 11 months ago

Fixed the argument for git status command so it looks into correct locales folder path.

openshift-ci-robot commented 11 months ago

@Mylanos: This pull request references Jira Issue OCPBUGS-17824, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.14.0) matches configured target version for branch (4.14.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @sanketpathak

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/console-plugin-template/pull/50): >Fixed the argument for git status command so it looks into correct locales folder path. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 11 months ago

@Mylanos: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
jhadvig commented 11 months ago

/approve

openshift-ci[bot] commented 11 months ago

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: jhadvig, Mylanos

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/console-plugin-template/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 11 months ago

@Mylanos: Jira Issue OCPBUGS-17824: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-17824 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/console-plugin-template/pull/50): >Fixed the argument for git status command so it looks into correct locales folder path. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.