openshift / console-plugin-template

Minimal template for writing OpenShift console plugins
Apache License 2.0
37 stars 47 forks source link

CONSOLE-3722: upgrade Cypress and switch default browser to Electron #54

Closed rhamilto closed 8 months ago

openshift-ci-robot commented 9 months ago

@rhamilto: This pull request references CONSOLE-3722 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to [this](https://github.com/openshift/console-plugin-template/pull/54): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
rhamilto commented 9 months ago

Work is tech debt and has no customer-facing impact.

/label docs-approved /label px-approved /label qe-approved

openshift-ci-robot commented 9 months ago

@rhamilto: This pull request references CONSOLE-3722 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to [this](https://github.com/openshift/console-plugin-template/pull/54): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
rhamilto commented 9 months ago

@cyril-ui-developer, PTAL

openshift-ci[bot] commented 9 months ago

@rhamilto: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
rhamilto commented 8 months ago

/approve

cyril-ui-developer commented 8 months ago

/lgtm

rhamilto commented 8 months ago

/label approved

openshift-ci[bot] commented 8 months ago

@rhamilto: Can not set label approved: Must be member in one of these teams: [openshift-release-oversight]

In response to [this](https://github.com/openshift/console-plugin-template/pull/54#issuecomment-1790912317): >/label approved Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
rhamilto commented 8 months ago

@spadgett, mind approving? Looks like we need to update the approvers list.

jcaianirh commented 8 months ago

@spadgett, mind approving? Looks like we need to update the approvers list.

cc: @vojtechszocs you're also on the approver list, if you could take a look that would be great.

openshift-ci[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, rhamilto, spadgett, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/console-plugin-template/blob/main/OWNERS)~~ [spadgett] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment