search

openshift / console-plugin-template

Minimal template for writing OpenShift console plugins
Apache License 2.0
40 stars 51 forks source link

OCPBUGS-24585: Avoid browser-caching failures #56

Closed jhadvig closed 9 months ago

jhadvig commented 10 months ago

/assign @simonpasquier @TheRealJon

openshift-ci-robot commented 10 months ago

@jhadvig: This pull request references Jira Issue OCPBUGS-24585, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/console-plugin-template/pull/56): >/assign @simonpasquier @TheRealJon Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
jhadvig commented 10 months ago

/jira refresh

openshift-ci-robot commented 10 months ago

@jhadvig: This pull request references Jira Issue OCPBUGS-24585, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/console-plugin-template/pull/56#issuecomment-1845371889): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/console-plugin-template/blob/main/OWNERS)~~ [jhadvig] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jhadvig commented 10 months ago

/jira refresh

openshift-ci-robot commented 10 months ago

@jhadvig: This pull request references Jira Issue OCPBUGS-24585, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.15.0) matches configured target version for branch (4.15.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @yapei

In response to [this](https://github.com/openshift/console-plugin-template/pull/56#issuecomment-1845373085): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 10 months ago

@jhadvig: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images e47248dfcf6a718a7827db4fa80712cb56d30053 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
spadgett commented 10 months ago

/cc @vojtechszocs

TheRealJon commented 9 months ago

https://github.com/openshift/console/pull/13272 has been backported to 4.13, does that make this PR obsolete?

spadgett commented 9 months ago

Yeah I think it's probably best to close this if If-Modified-Since handling works now out of the box with the template plugin. It's better to have caching than not as long as it's working.

/close

openshift-ci[bot] commented 9 months ago

@spadgett: Closed this PR.

In response to [this](https://github.com/openshift/console-plugin-template/pull/56#issuecomment-1878931576): >Yeah I think it's probably best to close this if `If-Modified-Since` handling works now out of the box with the template plugin. It's better to have caching than not as long as it's working. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 9 months ago

@jhadvig: This pull request references Jira Issue OCPBUGS-24585. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

In response to [this](https://github.com/openshift/console-plugin-template/pull/56): >/assign @simonpasquier @TheRealJon Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole-plugin-template). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.