openshift / console-plugin-template

Minimal template for writing OpenShift console plugins
Apache License 2.0
37 stars 47 forks source link

CONSOLE-3940: Upgrade dependencies #62

Closed sg00dwin closed 4 months ago

sg00dwin commented 4 months ago

https://issues.redhat.com/browse/CONSOLE-3940

openshift-ci-robot commented 4 months ago

@sg00dwin: This pull request references CONSOLE-3940 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift/console-plugin-template/pull/62): >https://issues.redhat.com/browse/CONSOLE-3940 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole-plugin-template). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
rhamilto commented 4 months ago

/retest

sg00dwin commented 4 months ago

/retest

sg00dwin commented 4 months ago

/retest

sg00dwin commented 4 months ago

/retest

vojtechszocs commented 4 months ago

/lgtm

sg00dwin commented 4 months ago

/retest

sg00dwin commented 4 months ago

/retest

sg00dwin commented 4 months ago

/retest

rhamilto commented 4 months ago

@sg00dwin, this PR doesn't build (which is why CI is failing).

❯ yarn start
yarn run v1.22.21
$ yarn ts-node node_modules/.bin/webpack serve
$ ts-node -O '{"module":"commonjs"}' node_modules/.bin/webpack serve
package.json (3 errors)
    Console provides shared module react-i18next ^11.7.3 but plugin uses version 13.0.0
    Console provides shared module react-router 5.3.x but plugin uses version 5.2.0
    Console provides shared module react-router-dom 5.3.x but plugin uses version 5.2.0
[webpack-cli] Failed to load '/Users/rhamilto/Git/console-plugin-template/webpack.config.ts' config
[webpack-cli] Error: Validation failed
    at ValidationResult.report (/Users/rhamilto/Git/console-plugin-template/node_modules/src/validation/ValidationResult.ts:75:15)
    at new ConsoleRemotePlugin (/Users/rhamilto/Git/console-plugin-template/node_modules/src/webpack/ConsoleRemotePlugin.ts:285:54)
    at Object.<anonymous> (/Users/rhamilto/Git/console-plugin-template/webpack.config.ts:75:5)
    at Module._compile (node:internal/modules/cjs/loader:1356:14)
    at Module.m._compile (/Users/rhamilto/Git/console-plugin-template/node_modules/ts-node/src/index.ts:1597:23)
    at Module._extensions..js (node:internal/modules/cjs/loader:1414:10)
    at Object.require.extensions.<computed> [as .ts] (/Users/rhamilto/Git/console-plugin-template/node_modules/ts-node/src/index.ts:1600:12)
    at Module.load (node:internal/modules/cjs/loader:1197:32)
    at Function.Module._load (node:internal/modules/cjs/loader:1013:12)
    at Module.require (node:internal/modules/cjs/loader:1225:19)
    at require (node:internal/modules/helpers:177:18)
    at WebpackCLI.tryRequireThenImport (/Users/rhamilto/Git/console-plugin-template/node_modules/webpack-cli/lib/webpack-cli.js:244:16)
    at loadConfigByPath (/Users/rhamilto/Git/console-plugin-template/node_modules/webpack-cli/lib/webpack-cli.js:1712:30)
    at WebpackCLI.loadConfig (/Users/rhamilto/Git/console-plugin-template/node_modules/webpack-cli/lib/webpack-cli.js:1832:36)
    at WebpackCLI.createCompiler (/Users/rhamilto/Git/console-plugin-template/node_modules/webpack-cli/lib/webpack-cli.js:2187:29)
    at Command.<anonymous> (/Users/rhamilto/Git/console-plugin-template/node_modules/@webpack-cli/serve/lib/index.js:106:40)
sg00dwin commented 4 months ago

/retest

openshift-ci[bot] commented 4 months ago

@sg00dwin: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
rhamilto commented 4 months ago

/lgtm QE Approver: /assign @yapei Docs Approver: /assign @opayne1 PX Approver: /assign @RickJWagner

rhamilto commented 4 months ago

/approve

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, sg00dwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/console-plugin-template/blob/main/OWNERS)~~ [rhamilto] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
RickJWagner commented 4 months ago

/label px-approved

XiyunZhao commented 4 months ago

This PR has been tested by following the guide in repo, and no issue was found, the example page is worked as expected /label qe-approved

openshift-ci-robot commented 4 months ago

@sg00dwin: This pull request references CONSOLE-3940 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift/console-plugin-template/pull/62): >https://issues.redhat.com/browse/CONSOLE-3940 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole-plugin-template). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
rhamilto commented 4 months ago

@opayne1, mind reviewing and approving?

opayne1 commented 4 months ago

/label docs-approved