search

openshift / console-plugin-template

Minimal template for writing OpenShift console plugins
Apache License 2.0
40 stars 51 forks source link

CONSOLE-4012: Improvements to Console plugin template #63

Closed vojtechszocs closed 5 months ago

vojtechszocs commented 6 months ago
openshift-ci-robot commented 6 months ago

@vojtechszocs: This pull request references CONSOLE-4012 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift/console-plugin-template/pull/63): >- Bump [Console dynamic plugin SDK](https://github.com/openshift/console/tree/master/frontend/packages/console-dynamic-plugin-sdk) dependencies to v1 latest >- Extract dynamic plugin metadata to `plugin-metadata.ts` >- Minor improvements in `package.json` scripts >- Minor improvements in `webpack.config.ts` Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole-plugin-template). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
vojtechszocs commented 6 months ago

@spadgett

I can't remember offhand how the chart determines the plugin name.

YAML templates at charts/openshift-console-plugin/templates refer to plugin name like so

{{ template "openshift-console-plugin.name" . }}

while the README says

Additional parameters can be specified if desired. Consult the chart values file for the full set of supported parameters.

so I'd say that plugin name has to be filled in charts/openshift-console-plugin/values.yaml manually.

openshift-ci-robot commented 6 months ago

@vojtechszocs: This pull request references CONSOLE-4012 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift/console-plugin-template/pull/63): >- Bump [Console dynamic plugin SDK](https://github.com/openshift/console/tree/master/frontend/packages/console-dynamic-plugin-sdk) dependencies to v1 latest >- Minor improvements in `package.json` scripts >- Minor improvements in `webpack.config.ts` Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole-plugin-template). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
vojtechszocs commented 6 months ago

@spadgett I've kept the dynamic plugin metadata in package.json file for now.

openshift-ci[bot] commented 6 months ago

@vojtechszocs: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TheRealJon, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/console-plugin-template/blob/main/OWNERS)~~ [TheRealJon,vojtechszocs] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
vojtechszocs commented 5 months ago

Adding the necessary labels, cc @jcaianirh

/label px-approved /label qe-approved /label docs-approved

openshift-ci-robot commented 5 months ago

@vojtechszocs: This pull request references CONSOLE-4012 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift/console-plugin-template/pull/63): >- Bump [Console dynamic plugin SDK](https://github.com/openshift/console/tree/master/frontend/packages/console-dynamic-plugin-sdk) dependencies to v1 latest >- Minor improvements in `package.json` scripts >- Minor improvements in `webpack.config.ts` Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole-plugin-template). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.