search

openshift / console-plugin-template

Minimal template for writing OpenShift console plugins
Apache License 2.0
37 stars 47 forks source link

OCPBUGS-32527: Remove unused "openshift" property in console-plugin-template / package.json #64

Closed cyril-ui-developer closed 3 months ago

cyril-ui-developer commented 3 months ago

/assign @vojtechszocs

openshift-ci-robot commented 3 months ago

@cyril-ui-developer: This pull request references Jira Issue OCPBUGS-32527, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/console-plugin-template/pull/64): >/assign @vojtechszocs Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole-plugin-template). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 3 months ago

@cyril-ui-developer: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
cyril-ui-developer commented 3 months ago

/jira refresh

openshift-ci-robot commented 3 months ago

@cyril-ui-developer: This pull request references Jira Issue OCPBUGS-32527, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/console-plugin-template/pull/64#issuecomment-2070128654): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole-plugin-template). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
cyril-ui-developer commented 3 months ago

/jira refresh

openshift-ci-robot commented 3 months ago

@cyril-ui-developer: This pull request references Jira Issue OCPBUGS-32527, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @yapei

In response to [this](https://github.com/openshift/console-plugin-template/pull/64#issuecomment-2070133871): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole-plugin-template). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
vojtechszocs commented 3 months ago

/lgtm

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cyril-ui-developer, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/console-plugin-template/blob/main/OWNERS)~~ [vojtechszocs] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 3 months ago

@cyril-ui-developer: Jira Issue OCPBUGS-32527: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-32527 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/console-plugin-template/pull/64): >/assign @vojtechszocs Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole-plugin-template). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.