search

openshift / console-plugin-template

Minimal template for writing OpenShift console plugins
Apache License 2.0
39 stars 51 forks source link

CONSOLE-3303: Move plugin template to the openshift GitHub org #9

Closed cyril-ui-developer closed 1 year ago

cyril-ui-developer commented 1 year ago

Screenshots: Running Cypress e2e tests in local env:

Screenshot 2022-12-13 at 2 11 58 PM Screenshot 2022-12-13 at 2 12 26 PM

Screencast:

https://user-images.githubusercontent.com/15249132/214329641-decd28ea-e644-4b62-a8ac-cb15d7d7a77d.mov

Steps to test locally:

  1. Build an image following the instructions in the main repo - console-plugin-template, and push to quay.io
  2. Set the env variable: export CYPRESS_PLUGIN_TEMPLATE_PULL_SPEC=quay.io/<username>/console-plugin-template
  3. Run yarn test-cypress Note: Helm is required to run the tests. See the instructions for installing helm here
jhadvig commented 1 year ago

Also do we need builder with nodejs-16 as a builder in the Dockerfile ? Asking since the last node version in the RH software collenctions is 10 and 12. Also 10 is already mirrored for CI use in here

cyril-ui-developer commented 1 year ago

@jcaianirh Updated the PR. PTAL.

jcaianirh commented 1 year ago

Ran this locally with success Screenshot 2023-01-04 at 11 56 58 AM

openshift-ci-robot commented 1 year ago

@cyril-ui-developer: This pull request references CONSOLE-3303 which is a valid jira issue.

In response to [this](https://github.com/openshift/console-plugin-template/pull/9): >Running Cypress e2e tests in local env: >Screenshot 2022-12-13 at 2 11 58 PM > >Screenshot 2022-12-13 at 2 12 26 PM > >### Screencast: > >https://user-images.githubusercontent.com/15249132/214329641-decd28ea-e644-4b62-a8ac-cb15d7d7a77d.mov > >### Steps to test locally: >1. Build an image following the instructions in the main repo - [ >console-plugin-template,](https://github.com/openshift/console-plugin-template#docker-image) and push to quay >2. Set the env variable: >`export CYPRESS_PLUGIN_TEMPLATE_PULL_SPEC=quay.io//console-plugin-template` >3. Run `yarn test-cypress` Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 1 year ago

@cyril-ui-developer: This pull request references CONSOLE-3303 which is a valid jira issue.

In response to [this](https://github.com/openshift/console-plugin-template/pull/9): >Running Cypress e2e tests in local env: >Screenshot 2022-12-13 at 2 11 58 PM > >Screenshot 2022-12-13 at 2 12 26 PM > >### Screencast: > >https://user-images.githubusercontent.com/15249132/214329641-decd28ea-e644-4b62-a8ac-cb15d7d7a77d.mov > >### Steps to test locally: >1. Build an image following the instructions in the main repo - [ >console-plugin-template,](https://github.com/openshift/console-plugin-template#docker-image) and push to quay >2. Set the env variable: >`export CYPRESS_PLUGIN_TEMPLATE_PULL_SPEC=quay.io//console-plugin-template` >3. Run `yarn test-cypress` >Note: Helm is required to run the tests. See the instructions for installing helm [here](https://helm.sh/docs/intro/install/) > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 1 year ago

@cyril-ui-developer: This pull request references CONSOLE-3303 which is a valid jira issue.

In response to [this](https://github.com/openshift/console-plugin-template/pull/9): >### Screenshots: Running Cypress e2e tests in local env: >Screenshot 2022-12-13 at 2 11 58 PM > >Screenshot 2022-12-13 at 2 12 26 PM > >### Screencast: > >https://user-images.githubusercontent.com/15249132/214329641-decd28ea-e644-4b62-a8ac-cb15d7d7a77d.mov > >### Steps to test locally: >1. Build an image following the instructions in the main repo - [ >console-plugin-template,](https://github.com/openshift/console-plugin-template#docker-image) and push to quay.io >2. Set the env variable: >`export CYPRESS_PLUGIN_TEMPLATE_PULL_SPEC=quay.io//console-plugin-template` >3. Run `yarn test-cypress` >Note: Helm is required to run the tests. See the instructions for installing helm [here](https://helm.sh/docs/intro/install/) > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
jhadvig commented 1 year ago

Tested locally ✅ /lgtm