openshift / console

OpenShift Cluster Console UI
https://www.openshift.org
Apache License 2.0
398 stars 605 forks source link

Locales base path is not respected #12671

Closed davidpanic closed 1 month ago

davidpanic commented 1 year ago

The console frontend does not respect the basePath when loading locales. I believe this is because of the following line:

https://github.com/openshift/console/blob/9ac23ec56263d23bf35fe1c71bf38b9220d944dc/frontend/public/i18n.js#L30

This results in 404 errors upon loading the UI:

image

I have launched the console bridge with the argument --base-path=/okd/ This is not very urgent as it appears that the console is visually still fully functional.

openshift-bot commented 1 year ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

davidpanic commented 1 year ago

/remove-lifecycle stale

Still an issue.

openshift-bot commented 1 year ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

davidpanic commented 1 year ago

/remove-lifecycle stale

Still an issue.

openshift-bot commented 9 months ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

davidpanic commented 9 months ago

/remove-lifecycle stale

Still an issue.

openshift-bot commented 6 months ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

davidpanic commented 6 months ago

/remove-lifecycle stale

Still an issue.

openshift-bot commented 3 months ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

davidpanic commented 2 months ago

/remove-lifecycle stale

Still an issue.

logonoff commented 2 months ago

good catch! i've opened a merge request #14046 to fix your issue--if merged, it may appear in a future release

cheers :smile:

logonoff commented 2 months ago

/assign @logonoff