search

openshift / console

OpenShift Cluster Console UI
https://www.openshift.org
Apache License 2.0
402 stars 615 forks source link

Misconfigured form validation/interaction preventing EditApplication.tsx form submission #13906

Closed duckboy81 closed 8 hours ago

duckboy81 commented 6 months ago

Issue

When editing an application, the form's save button will never be enabled due to missing unseen required items.

Details

The imageValidationSchema function in validation-schema.ts requires the selected and tag properties. However, when editing my application, the initialValue that gets passed down has an object at .image with empty strings for the selected and the tag properties, resulting in an immediate error and disabling the SAVE button.

image

To reproduce

  1. Developer -> +Add
  2. Import from Git
    • Git repo URL: Use URL of "unreachable" repo (get URL is valid but cannot be reached msg) -- PS: The pipeline has no problem reaching it later...
    • Git type: GitLab
    • Import strategy: Dockerfile
    • Build option: Pipelines
    • Pipeline: buildah-deployment
  3. Create
  4. From the topology map, "Edit \<name of deployment>"
  5. Save button is not enabled
duckboy81 commented 6 months ago

And validation error object for reference:

image

spadgett commented 5 months ago

/kind bug /assign @vikram-raj

openshift-bot commented 2 months ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot commented 1 month ago

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot commented 8 hours ago

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci[bot] commented 8 hours ago

@openshift-bot: Closing this issue.

In response to [this](https://github.com/openshift/console/issues/13906#issuecomment-2533260191): >Rotten issues close after 30d of inactivity. > >Reopen the issue by commenting `/reopen`. >Mark the issue as fresh by commenting `/remove-lifecycle rotten`. >Exclude this issue from closing again by commenting `/lifecycle frozen`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.