search

openshift / console

OpenShift Cluster Console UI
https://www.openshift.org
Apache License 2.0
393 stars 601 forks source link

Misconfigured form validation/interaction preventing EditApplication.tsx form submission #13906

Open duckboy81 opened 1 month ago

duckboy81 commented 1 month ago

Issue

When editing an application, the form's save button will never be enabled due to missing unseen required items.

Details

The imageValidationSchema function in validation-schema.ts requires the selected and tag properties. However, when editing my application, the initialValue that gets passed down has an object at .image with empty strings for the selected and the tag properties, resulting in an immediate error and disabling the SAVE button.

image

To reproduce

  1. Developer -> +Add
  2. Import from Git
    • Git repo URL: Use URL of "unreachable" repo (get URL is valid but cannot be reached msg) -- PS: The pipeline has no problem reaching it later...
    • Git type: GitLab
    • Import strategy: Dockerfile
    • Build option: Pipelines
    • Pipeline: buildah-deployment
  3. Create
  4. From the topology map, "Edit \<name of deployment>"
  5. Save button is not enabled
duckboy81 commented 1 month ago

And validation error object for reference:

image

spadgett commented 1 week ago

/kind bug /assign @vikram-raj