openshift / console

OpenShift Cluster Console UI
https://www.openshift.org
Apache License 2.0
397 stars 607 forks source link

OCPBUGS-36705: Plugins that use very old PF4 dropdown or menu components with grouped items have bullets and padding that needs to be removed. #14324

Closed sg00dwin closed 6 days ago

sg00dwin commented 1 week ago

before image

after Screenshot 2024-09-24 at 12 11 30 PM

openshift-ci-robot commented 1 week ago

@sg00dwin: This pull request references Jira Issue OCPBUGS-36705, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/console/pull/14324): >**before** >![image](https://github.com/user-attachments/assets/55cce056-8869-4935-9439-892502973525) > > >**after** >![Screenshot 2024-09-24 at 12 11 30 PM](https://github.com/user-attachments/assets/9b5c4939-214c-4fe9-9f40-27dcc3cf72eb) > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
sg00dwin commented 1 week ago

/jira refresh

openshift-ci-robot commented 1 week ago

@sg00dwin: This pull request references Jira Issue OCPBUGS-36705, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @yapei

In response to [this](https://github.com/openshift/console/pull/14324#issuecomment-2372036451): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
sg00dwin commented 1 week ago

/cherry-pick release-4.17 release-4.16 release-4.15

openshift-cherrypick-robot commented 1 week ago

@sg00dwin: once the present PR merges, I will cherry-pick it on top of release-4.17 in a new PR and assign it to you.

In response to [this](https://github.com/openshift/console/pull/14324#issuecomment-2372037514): >/cherry-pick release-4.17 release-4.16 release-4.15 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
sg00dwin commented 1 week ago

/test e2e-gcp-console

openshift-ci[bot] commented 1 week ago

@sg00dwin: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci[bot] commented 6 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, sg00dwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[frontend/public/style/OWNERS](https://github.com/openshift/console/blob/master/frontend/public/style/OWNERS)~~ [rhamilto,sg00dwin] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 6 days ago

@sg00dwin: Jira Issue OCPBUGS-36705: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-36705 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/console/pull/14324): >**before** >![image](https://github.com/user-attachments/assets/55cce056-8869-4935-9439-892502973525) > > >**after** >![Screenshot 2024-09-24 at 12 11 30 PM](https://github.com/user-attachments/assets/9b5c4939-214c-4fe9-9f40-27dcc3cf72eb) > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-cherrypick-robot commented 6 days ago

@sg00dwin: new pull request created: #14344

In response to [this](https://github.com/openshift/console/pull/14324#issuecomment-2372037514): >/cherry-pick release-4.17 release-4.16 release-4.15 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 6 days ago

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console This PR has been included in build openshift-enterprise-console-container-v4.18.0-202409280110.p0.gd242415.assembly.stream.el9. All builds following this will include this PR.