openshift / console

OpenShift Cluster Console UI
https://www.openshift.org
Apache License 2.0
397 stars 607 forks source link

OCPBUGS-42418: Solved the knative test issue when instances are not present #14325

Closed sanketpathak closed 6 days ago

sanketpathak commented 1 week ago

Issue: https://issues.redhat.com/browse/OCPBUGS-42418

Before: Screenshot from 2024-09-25 14-02-29

Now: Screenshot from 2024-09-25 14-47-35

openshift-ci-robot commented 1 week ago

@sanketpathak: This pull request references Jira Issue OCPBUGS-42418, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/console/pull/14325): >Issue: https://issues.redhat.com/browse/OCPBUGS-42418 > >Before: >![Screenshot from 2024-09-25 14-02-29](https://github.com/user-attachments/assets/b77f86dc-b31a-4687-bca6-6dd987811161) > > >Now: >![Screenshot from 2024-09-25 14-47-35](https://github.com/user-attachments/assets/0c5b8703-5526-4066-8335-dae3d9306cf6) > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 week ago

@logonoff: This pull request references Jira Issue OCPBUGS-42418, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @sanketpathak

In response to [this](https://github.com/openshift/console/pull/14325#issuecomment-2375079302): >/jira refresh > >Tests don't seem to be working when I run them locally > >![image](https://github.com/user-attachments/assets/9a6dec65-e493-4a51-9348-09a047c72eaa) > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 week ago

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: sanketpathak.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/openshift/console/pull/14325#issuecomment-2375079440): >@logonoff: This pull request references [Jira Issue OCPBUGS-42418](https://issues.redhat.com//browse/OCPBUGS-42418), which is valid. > >
3 validation(s) were run on this bug > >* bug is open, matching expected state (open) >* bug target version (4.18.0) matches configured target version for branch (4.18.0) >* bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @sanketpathak

In response to [this](https://github.com/openshift/console/pull/14325#issuecomment-2375079302): >/jira refresh > >Tests don't seem to be working when I run them locally > >![image](https://github.com/user-attachments/assets/9a6dec65-e493-4a51-9348-09a047c72eaa) > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

sanketpathak commented 1 week ago

Tests don't seem to be working when I run them locally

image

/jira refresh

The bug only fixes the issue with knative installation script when any CR instance is missing in a cluster with knative operator already installed. But I'll push the change for the issue you are facing.

openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, sanketpathak, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[frontend/packages/dev-console/integration-tests/OWNERS](https://github.com/openshift/console/blob/master/frontend/packages/dev-console/integration-tests/OWNERS)~~ [sanketpathak,vikram-raj] - ~~[frontend/packages/integration-tests-cypress/OWNERS](https://github.com/openshift/console/blob/master/frontend/packages/integration-tests-cypress/OWNERS)~~ [vikram-raj] - ~~[frontend/packages/knative-plugin/integration-tests/OWNERS](https://github.com/openshift/console/blob/master/frontend/packages/knative-plugin/integration-tests/OWNERS)~~ [sanketpathak,vikram-raj] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 6 days ago

@sanketpathak: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 6 days ago

@sanketpathak: Jira Issue OCPBUGS-42418: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-42418 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/console/pull/14325): >Issue: https://issues.redhat.com/browse/OCPBUGS-42418 > >Before: >![Screenshot from 2024-09-25 14-02-29](https://github.com/user-attachments/assets/b77f86dc-b31a-4687-bca6-6dd987811161) > > >Now: >![Screenshot from 2024-09-25 14-47-35](https://github.com/user-attachments/assets/0c5b8703-5526-4066-8335-dae3d9306cf6) > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 6 days ago

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console This PR has been included in build openshift-enterprise-console-container-v4.18.0-202409280309.p0.g9789f25.assembly.stream.el9. All builds following this will include this PR.