Open rhamilto opened 1 week ago
@rhamilto: This pull request references CONSOLE-4139 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
@rhamilto: This pull request references CONSOLE-4139 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
/assign @TheRealJon /assign @yapei
Adding approvals since this is tech debt: /label px-approved /label docs-approved
/retest
@rhamilto: all tests passed!
Full PR test history. Your PR dashboard.
tested the PR and no regression issues found /label qe-approved
@rhamilto: This pull request references CONSOLE-4139 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
I'm testing on a cluster-bot cluster launch openshift/console#14327
and seeing different behavior for an external link, after content is copied, it shows 'copied to clipboard' (for secret data it shows 'copied')
https://github.com/user-attachments/assets/35952f57-7ae9-46bc-9b54-246f99df4bf5
@rhamilto: This pull request references CONSOLE-4139 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
I'm testing on a cluster-bot cluster
launch openshift/console#14327
and seeing different behavior for an external link, after content is copied, it shows 'copied to clipboard' (for secret data it shows 'copied')
Good catch, @yapei. It turns out the ExternalLinkWithCopy
component has been duplicated in https://github.com/openshift/networking-console-plugin and the bug exists there (in addition to that duplicated component needing to be updated to use CopyClipboardButton
). I've opened https://issues.redhat.com/browse/CNV-49317 to address.
/hold
I should be able to convert the exiting unit test to RTL using https://testing-library.com/docs/user-event/clipboard/
@rhamilto: This pull request references CONSOLE-4139 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
/assign @jhadvig
/hold cancel
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jhadvig, rhamilto
The full list of commands accepted by this bot can be found here.
The pull request process is described here
…rdCopyButton component
There are additional instances of
react-copy-to-clipboard
that will be addressed by:After
https://github.com/user-attachments/assets/44c8f67c-8f38-4ab6-ba06-353865deb7b8
https://github.com/user-attachments/assets/1b5393cc-81f6-4048-b50c-f3a8d2fc761c