search

openshift / console

OpenShift Cluster Console UI
https://www.openshift.org
Apache License 2.0
397 stars 607 forks source link

OCPBUGS-33519: Observe > Metrics targets, Alert user if they do not have access to information on this page (e.g. 403). #14334

Closed jgbernalp closed 2 days ago

jgbernalp commented 1 week ago

Manual cherry pick of #12319 (OCPBUGS-3373)

Fixes: https://issues.redhat.com/browse/OCPBUGS-33519

openshift-ci-robot commented 1 week ago

@jgbernalp: This pull request references Jira Issue OCPBUGS-33519, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/console/pull/14334): >Manual cherry pick of #12319 (OCPBUGS-3373) > >Fixes: https://issues.redhat.com/browse/OCPBUGS-33519 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jgbernalp commented 1 week ago

/jira refresh

openshift-ci-robot commented 1 week ago

@jgbernalp: This pull request references Jira Issue OCPBUGS-33519, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.12.z) matches configured target version for branch (4.12.z) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST) * release note text is set and does not match the template * dependent bug [Jira Issue OCPBUGS-3373](https://issues.redhat.com//browse/OCPBUGS-3373) is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-3373](https://issues.redhat.com//browse/OCPBUGS-3373) targets the "4.13.0" version, which is one of the valid target versions: 4.13.0, 4.13.z * bug has dependents

Requesting review from QA contact: /cc @juzhao

In response to [this](https://github.com/openshift/console/pull/14334#issuecomment-2376474127): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jgbernalp commented 4 days ago

/retest

openshift-ci[bot] commented 4 days ago

@jgbernalp: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
juzhao commented 4 days ago

/label cherry-pick-approved

jhadvig commented 2 days ago

/label backport-risk-assessed,

openshift-ci[bot] commented 2 days ago

@jhadvig: The label(s) /label backport-risk-assessed, cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to [this](https://github.com/openshift/console/pull/14334#issuecomment-2388087340): >/label backport-risk-assessed, Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 2 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgbernalp, jhadvig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[frontend/OWNERS](https://github.com/openshift/console/blob/release-4.12/frontend/OWNERS)~~ [jhadvig] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jhadvig commented 2 days ago

/label backport-risk-assessed

openshift-ci-robot commented 2 days ago

@jgbernalp: Jira Issue OCPBUGS-33519: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-33519 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/console/pull/14334): >Manual cherry pick of #12319 (OCPBUGS-3373) > >Fixes: https://issues.redhat.com/browse/OCPBUGS-33519 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 2 days ago

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console This PR has been included in build openshift-enterprise-console-container-v4.12.0-202410021031.p0.g1f41bda.assembly.stream.el8. All builds following this will include this PR.

openshift-merge-robot commented 2 days ago

Fix included in accepted release 4.12.0-0.nightly-2024-10-02-113011