search

openshift / console

OpenShift Cluster Console UI
https://www.openshift.org
Apache License 2.0
397 stars 607 forks source link

ODC-7680: Migrate `FilterTable` to PF5 #14340

Open logonoff opened 1 week ago

logonoff commented 1 week ago

Fixes:

https://issues.redhat.com/browse/ODC-7680

Solution Description:

migrate file to PF5 tables and remove unlocalized strings

Screen shots / Gifs for design review:

https://github.com/user-attachments/assets/b1c369de-e42e-4e54-b760-718d05280b48

Unit test coverage report:

n/a

Test setup:

install knative operator, set up knative servicing, then add a trigger with a filter

Browser conformance:

openshift-ci-robot commented 1 week ago

@logonoff: This pull request references ODC-7680 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/console/pull/14340): >**Fixes**: > >https://issues.redhat.com/browse/ODC-7680 > >**Solution Description**: > >migrate file to PF5 tables and remove unlocalized strings > >**Screen shots / Gifs for design review**: > > >https://github.com/user-attachments/assets/b1c369de-e42e-4e54-b760-718d05280b48 > >**Unit test coverage report**: > >n/a > >**Test setup:** > >install knative operator, set up knative servicing, then add a trigger with a filter > >**Browser conformance**: > >- [x] Chrome >- [x] Firefox >- [ ] Safari Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: logonoff Once this PR has been reviewed and has the lgtm label, please assign divyanshigupta for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[frontend/packages/knative-plugin/OWNERS](https://github.com/openshift/console/blob/master/frontend/packages/knative-plugin/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
logonoff commented 2 days ago

/retest

openshift-ci[bot] commented 2 days ago

@logonoff: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).