openshift / console

OpenShift Cluster Console UI
https://www.openshift.org
Apache License 2.0
402 stars 615 forks source link

ODC-7680: Migrate `ResultsList` to PF5 #14343

Closed logonoff closed 1 month ago

logonoff commented 2 months ago

Fixes:

https://issues.redhat.com/browse/ODC-7680

Solution Description:

Migrate ResultsList to PF5

Screen shots / Gifs for design review:

https://github.com/user-attachments/assets/f1b937d7-9cd6-4e7e-96f9-a39ce82cd4a1

Unit test coverage report:

unchanged

Test setup:

n/a

Browser conformance:

This pr is 2/? of ODC-7680 story as each file is being split into a separate PR.

openshift-ci-robot commented 2 months ago

@logonoff: This pull request references ODC-7680 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/console/pull/14343): >**Fixes**: > >https://issues.redhat.com/browse/ODC-7680 > >**Solution Description**: > >Migrate ResultsList to PF5 > >I commented out the input validation UI because it is not supported in our currently installed version of PatternFly > >**Screen shots / Gifs for design review**: > > >https://github.com/user-attachments/assets/f1b937d7-9cd6-4e7e-96f9-a39ce82cd4a1 > >**Unit test coverage report**: > >unchanged > >**Test setup:** > >n/a > >**Browser conformance**: > >- [x] Chrome >- [x] Firefox >- [ ] Safari > >This pr is 2/? of [ODC-7680](https://issues.redhat.com//browse/ODC-7680) story as each file is being split into a separate PR. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
logonoff commented 2 months ago

/retest

openshift-ci-robot commented 2 months ago

@logonoff: This pull request references ODC-7680 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/console/pull/14343): >**Fixes**: > >https://issues.redhat.com/browse/ODC-7680 > >**Solution Description**: > >Migrate ResultsList to PF5 > >**Screen shots / Gifs for design review**: > > >https://github.com/user-attachments/assets/f1b937d7-9cd6-4e7e-96f9-a39ce82cd4a1 > >**Unit test coverage report**: > >unchanged > >**Test setup:** > >n/a > >**Browser conformance**: > >- [x] Chrome >- [x] Firefox >- [ ] Safari > >This pr is 2/? of [ODC-7680](https://issues.redhat.com//browse/ODC-7680) story as each file is being split into a separate PR. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, lokanandaprabhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[frontend/packages/pipelines-plugin/OWNERS](https://github.com/openshift/console/blob/master/frontend/packages/pipelines-plugin/OWNERS)~~ [lokanandaprabhu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
logonoff commented 1 month ago

adding labels because this is debt

/label px-approved /label docs-approved

sanketpathak commented 1 month ago

Verified the UI and the tests. Screenshot from 2024-10-16 17-09-36 /label qe-approved

openshift-ci-robot commented 1 month ago

@logonoff: This pull request references ODC-7680 which is a valid jira issue.

In response to [this](https://github.com/openshift/console/pull/14343): >**Fixes**: > >https://issues.redhat.com/browse/ODC-7680 > >**Solution Description**: > >Migrate ResultsList to PF5 > >**Screen shots / Gifs for design review**: > > >https://github.com/user-attachments/assets/f1b937d7-9cd6-4e7e-96f9-a39ce82cd4a1 > >**Unit test coverage report**: > >unchanged > >**Test setup:** > >n/a > >**Browser conformance**: > >- [x] Chrome >- [x] Firefox >- [ ] Safari > >This pr is 2/? of [ODC-7680](https://issues.redhat.com//browse/ODC-7680) story as each file is being split into a separate PR. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

@logonoff: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console This PR has been included in build openshift-enterprise-console-container-v4.18.0-202410162341.p0.g3f55ee6.assembly.stream.el9. All builds following this will include this PR.