Closed Mylanos closed 2 weeks ago
@Mylanos: This pull request references Jira Issue OCPBUGS-41175, which is invalid:
Comment /jira refresh
to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
The bug has been updated to refer to the pull request using the external bug tracker.
Hi @Mylanos. Thanks for your PR.
I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/jira refresh
@Mylanos: This pull request references Jira Issue OCPBUGS-41175, which is valid. The bug has been moved to the POST state.
Requesting review from QA contact: /cc @XiyunZhao
/ok-to-test
@Mylanos: This pull request references Jira Issue OCPBUGS-41175, which is valid.
Requesting review from QA contact: /cc @XiyunZhao
The bug has been updated to refer to the pull request using the external bug tracker.
After making the initial change that fixed the issue of not showing the correct description for a given channel, a problem of unstable styling within the MarkdownView
popped up, which can be seen on the following screen recording.
https://github.com/user-attachments/assets/74770aaf-d1b8-4474-b70f-d6db1732e7f5
Cause of problem was that the iframe
component the MarkdownView
uses, was mounting/creating new iframe
component each time the content/description has changed, which caused the styling to be reapplied over and over again ( the CSS styling is defined within the HTML page that is being generated in this component and passed to the iframe
). Which resulted in a problem where the styling was inconsistent - most notable issue was that the background color flashed to white.
To resolve this issue I kept the iframe
mounted and only made changes to its content based on the current description/content, while keeping the onLoad
logic. The content is being injected into the iframe
instead of using the srcDoc
, every time it changes.
After these changes, the flickering problem does not occur.
https://github.com/user-attachments/assets/3772f8a2-970e-40de-bd9e-aa80ae3a8fc4
/retest
/retest
/retest
/retest
Thanks for the review @vojtechszocs and @rhamilto, updated the PR with those recommended changes 👍
/retest
/retest
/retest
/retest
/retest
/retest
/retest
@Mylanos: all tests passed!
Full PR test history. Your PR dashboard.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Mylanos, TheRealJon, vojtechszocs
The full list of commands accepted by this bot can be found here.
The pull request process is described here
@Mylanos: Jira Issue OCPBUGS-41175: All pull requests linked via external trackers have merged:
Jira Issue OCPBUGS-41175 has been moved to the MODIFIED state.
Links to: https://issues.redhat.com/browse/OCPBUGS-41175
Problem: The description of the operator hub item didnt show accordingly to the selected channel.
Fix: Pass the description from the
currentCSVDesc
to theMarkdownView
instead of the longDescription, that is derived from the default channel.Before:
After