openshift / console

OpenShift Cluster Console UI
https://www.openshift.org
Apache License 2.0
401 stars 613 forks source link

OCPBUGS-41492: show Samples tab when one or more exists #14350

Closed rhamilto closed 1 month ago

rhamilto commented 1 month ago

After

If creating new and sample and snippet exist, both tabs appear; if neither sample not snippet exist, no tabs show:

https://github.com/user-attachments/assets/52d9ab48-8e76-4ce4-9e9f-f6722908dada

If editing existing and sample and snippet exist, only snippet tab appears:

https://github.com/user-attachments/assets/24104507-43a0-446e-b694-bdd024cf8243

openshift-ci-robot commented 1 month ago

@rhamilto: This pull request references Jira Issue OCPBUGS-41492, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/console/pull/14350): > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
rhamilto commented 1 month ago

/jira refresh

openshift-ci-robot commented 1 month ago

@rhamilto: This pull request references Jira Issue OCPBUGS-41492, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @yapei

In response to [this](https://github.com/openshift/console/pull/14350#issuecomment-2383521901): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@rhamilto: This pull request references Jira Issue OCPBUGS-41492, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @yapei

In response to [this](https://github.com/openshift/console/pull/14350): >After > >If creating new and sample and snippet exist, both tabs appear; if neither sample not snippet exist, no tabs show: > >https://github.com/user-attachments/assets/52d9ab48-8e76-4ce4-9e9f-f6722908dada > >If editing existing and sample and snippet exist, only snippet tab appears: > >https://github.com/user-attachments/assets/24104507-43a0-446e-b694-bdd024cf8243 > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
rhamilto commented 1 month ago

/retest

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[frontend/OWNERS](https://github.com/openshift/console/blob/master/frontend/OWNERS)~~ [jhadvig,rhamilto] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
rhamilto commented 1 month ago

/retest

openshift-ci[bot] commented 1 month ago

@rhamilto: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 1 month ago

@rhamilto: Jira Issue OCPBUGS-41492: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-41492 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/console/pull/14350): >After > >If creating new and sample and snippet exist, both tabs appear; if neither sample not snippet exist, no tabs show: > >https://github.com/user-attachments/assets/52d9ab48-8e76-4ce4-9e9f-f6722908dada > >If editing existing and sample and snippet exist, only snippet tab appears: > >https://github.com/user-attachments/assets/24104507-43a0-446e-b694-bdd024cf8243 > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console This PR has been included in build openshift-enterprise-console-container-v4.18.0-202410080612.p0.g585e061.assembly.stream.el9. All builds following this will include this PR.