search

openshift / console

OpenShift Cluster Console UI
https://www.openshift.org
Apache License 2.0
401 stars 613 forks source link

[release-4.16] OCPBUGS-36556: Increase login flow state paramater length/entropy #14354

Closed openshift-cherrypick-robot closed 1 month ago

openshift-cherrypick-robot commented 1 month ago

This is an automated cherry-pick of #14318

/assign jhadvig

openshift-ci-robot commented 1 month ago

@openshift-cherrypick-robot: Detected clone of Jira Issue OCPBUGS-42299 with correct target version. Will retitle the PR to link to the clone. /retitle [release-4.16] OCPBUGS-36556: Increase login flow state paramater length/entropy

In response to [this](https://github.com/openshift/console/pull/14354): >This is an automated cherry-pick of #14318 > >/assign jhadvig Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-36556, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/console/pull/14354): >This is an automated cherry-pick of #14318 > >/assign jhadvig Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jhadvig commented 1 month ago

/cherry-pick release-4.15

openshift-cherrypick-robot commented 1 month ago

@jhadvig: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you.

In response to [this](https://github.com/openshift/console/pull/14354#issuecomment-2411567994): >/cherry-pick release-4.15 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
jhadvig commented 1 month ago

/approve /label backport-risk-assessed

jhadvig commented 1 month ago

/jira refresh

openshift-ci-robot commented 1 month ago

@jhadvig: This pull request references Jira Issue OCPBUGS-36556, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.z) matches configured target version for branch (4.16.z) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST) * release note type set to "Release Note Not Required" * dependent bug [Jira Issue OCPBUGS-42299](https://issues.redhat.com//browse/OCPBUGS-42299) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-42299](https://issues.redhat.com//browse/OCPBUGS-42299) targets the "4.17.z" version, which is one of the valid target versions: 4.17.0, 4.17.z * bug has dependents

Requesting review from QA contact: /cc @yapei

In response to [this](https://github.com/openshift/console/pull/14354#issuecomment-2411569290): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
yanpzhan commented 1 month ago

Checked on cluster launched against the pr, accessed console url, checked "state" parameter in login redirect url, it's 16 bytes. /label qe-approved /label cherry-pick-approved

openshift-ci-robot commented 1 month ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-36556, which is valid.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.z) matches configured target version for branch (4.16.z) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST) * release note type set to "Release Note Not Required" * dependent bug [Jira Issue OCPBUGS-42299](https://issues.redhat.com//browse/OCPBUGS-42299) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-42299](https://issues.redhat.com//browse/OCPBUGS-42299) targets the "4.17.z" version, which is one of the valid target versions: 4.17.0, 4.17.z * bug has dependents

Requesting review from QA contact: /cc @yapei

In response to [this](https://github.com/openshift/console/pull/14354): >This is an automated cherry-pick of #14318 > >/assign jhadvig Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jhadvig commented 1 month ago

/lgtm

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/auth/OWNERS](https://github.com/openshift/console/blob/release-4.16/pkg/auth/OWNERS)~~ [jhadvig] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 95b891641aa974ed2f653b50db644d75ad6c6982 and 2 for PR HEAD 20eb86e05f0c5d4622a63141ef6d1e5d7cb0f837 in total

openshift-ci[bot] commented 1 month ago

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 1 month ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-36556: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-36556 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/console/pull/14354): >This is an automated cherry-pick of #14318 > >/assign jhadvig Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-cherrypick-robot commented 1 month ago

@jhadvig: new pull request created: #14422

In response to [this](https://github.com/openshift/console/pull/14354#issuecomment-2411567994): >/cherry-pick release-4.15 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console This PR has been included in build openshift-enterprise-console-container-v4.16.0-202410211837.p0.gf0870c3.assembly.stream.el9. All builds following this will include this PR.

openshift-merge-robot commented 1 month ago

Fix included in accepted release 4.16.0-0.nightly-2024-10-22-003418